Comments on: JavaScript reduce http://christopherowen.id.au/blog/2008/07/08/javascript-reduce/ Stuff cubed plus one Fri, 07 Jan 2011 21:47:07 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Bookmarks about Javascript http://christopherowen.id.au/blog/2008/07/08/javascript-reduce/comment-page-1/#comment-7107 Bookmarks about Javascript Wed, 13 Aug 2008 19:45:17 +0000 http://christopherowen.id.au/blog/?p=42#comment-7107 [...] - bookmarked by 4 members originally found by marthitacisneros on 2008-07-20 JavaScript reduce http://christopherowen.id.au/blog/2008/07/08/javascript-reduce/ - bookmarked by 3 members [...] [...] – bookmarked by 4 members originally found by marthitacisneros on 2008-07-20 JavaScript reduce http://christopherowen.id.au/blog/2008/07/08/javascript-reduce/ – bookmarked by 3 members [...]

]]> By: Matt Ryall http://christopherowen.id.au/blog/2008/07/08/javascript-reduce/comment-page-1/#comment-7083 Matt Ryall Tue, 08 Jul 2008 23:12:45 +0000 http://christopherowen.id.au/blog/?p=42#comment-7083 Wow, that is cool. Using all four arguments of the reduce function is impressive. :) Rather than using reduce, you could make group() recursive and pass the output array to it. This might make the array manipulation a bit easier because you don't have to return it: <pre lang="javascript">previousValue[-1] = previousValue[-1].concat(currentValue);</pre> Not very functional, perhaps. :) It took me a while to understand why you're putting double brackets around this: <pre lang="javascript">return previousValue.concat([[currentValue]]);</pre> The overloaded argument handling of Array.concat is quite annoying in this case. Wow, that is cool. Using all four arguments of the reduce function is impressive. :)

Rather than using reduce, you could make group() recursive and pass the output array to it. This might make the array manipulation a bit easier because you don’t have to return it:

previousValue[-1] = previousValue[-1].concat(currentValue);

Not very functional, perhaps. :)

It took me a while to understand why you’re putting double brackets around this:

return previousValue.concat([[currentValue]]);

The overloaded argument handling of Array.concat is quite annoying in this case.

]]>